netdev - RE: [PATCH v2 bpf 0/2] tcp_bpf: update the rmem scheduling for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6765a094c9db5_21de2208d9@john.notmuch>
Date: Fri, 20 Dec 2024 08:51:32 -0800
From: John Fastabend <john.fastabend@...il.com>
To: zijianzhang@...edance.com, 
 bpf@...r.kernel.org
Cc: john.fastabend@...il.com, 
 jakub@...udflare.com, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 dsahern@...nel.org, 
 horms@...nel.org, 
 ast@...nel.org, 
 daniel@...earbox.net, 
 netdev@...r.kernel.org, 
 Zijian Zhang <zijianzhang@...edance.com>
Subject: RE: [PATCH v2 bpf 0/2] tcp_bpf: update the rmem scheduling for

zijianzhang@ wrote:
> From: Zijian Zhang <zijianzhang@...edance.com>
> 
> We should do sk_rmem_schedule instead of sk_wmem_schedule in function
> bpf_tcp_ingress. We also need to update sk_rmem_alloc in bpf_tcp_ingress
> accordingly to account for the rmem.
> 
> v2:
>   - Update the commit message to indicate the reason for msg->skb check
> 
> Cong Wang (1):
>   tcp_bpf: charge receive socket buffer in bpf_tcp_ingress()
> 
> Zijian Zhang (1):
>   tcp_bpf: add sk_rmem_alloc related logic for tcp_bpf ingress
>     redirection
> 
>  include/linux/skmsg.h | 11 ++++++++---
>  include/net/sock.h    | 10 ++++++++--
>  net/core/skmsg.c      |  6 +++++-
>  net/ipv4/tcp_bpf.c    |  6 ++++--
>  4 files changed, 25 insertions(+), 8 deletions(-)
> 
> -- 
> 2.20.1
> 

Thanks. Sorry fo rthe delay I thought this had an ACK already. My fault.

Reviewed-by: John Fastabend <john.fastabend@...il.com>