netdev - Re: [PATCH net 0/2] Fix NPE discovered by running bpf kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6765a1d89686a_21de220813@john.notmuch>
Date: Fri, 20 Dec 2024 08:56:56 -0800
From: John Fastabend <john.fastabend@...il.com>
To: Björn Töpel <bjorn@...nel.org>, 
 John Fastabend <john.fastabend@...il.com>, 
 Levi Zim <rsworktech@...look.com>, 
 Cong Wang <xiyou.wangcong@...il.com>, 
 John Fastabend <john.fastabend@...il.com>
Cc: Jakub Sitnicki <jakub@...udflare.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 David Ahern <dsahern@...nel.org>, 
 netdev@...r.kernel.org, 
 bpf@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 0/2] Fix NPE discovered by running bpf kselftest

Björn Töpel wrote:
> John Fastabend <john.fastabend@...il.com> writes:
> 
> >> Took the series for a run, and it does solve crash, but I'm getting
> >> additional failures:
> >
> > Thanks! I'm guessing those tests were failing even without the patch
> > though right?
> 
> Correct.

Thanks Bjorn!

> 
> test_sockmap did however pass the full suite in 6.12. So, something
> changed with the addition of [1].

Agree with finding this. I also have a compliance test failing in one
of our nginx/apache/bpf test suites so might be related. I'll dig into
it.

> 
> I guess:
> 
> Tested-by: Björn Töpel <bjorn@...nel.org>

Because when I find the bug that gets here I would have stacked this on
top of any fix as well I think lets apply this now.

Reviewed-by: John Fastabend <john.fastabend@...il.com>

> 
> can be added to this series, and not crashing is nice, but it would be
> interesting to know how it got there.
> 
> 
> Björn
> 
> 
> [1] https://lore.kernel.org/all/20241106222520.527076-1-zijianzhang@bytedance.com/
>