netdev - Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241220132413.0962ad79@kernel.org>
Date: Fri, 20 Dec 2024 13:24:13 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gur Stavi <gur.stavi@...wei.com>
Cc: gongfan <gongfan1@...wei.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 <linux-doc@...r.kernel.org>, Jonathan Corbet <corbet@....net>, Bjorn
 Helgaas <helgaas@...nel.org>, Cai Huoqing <cai.huoqing@...ux.dev>, Xin Guo
 <guoxin09@...wei.com>, Shen Chenyang <shenchenyang1@...ilicon.com>, Zhou
 Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>, Shi Jing
 <shijing34@...wei.com>, Meny Yossefi <meny.yossefi@...wei.com>
Subject: Re: [PATCH net-next v01 1/1] hinic3: module initialization and
 tx/rx logic

On Thu, 19 Dec 2024 11:21:55 +0200 Gur Stavi wrote:
> +config HINIC3
> +	tristate "Huawei Intelligent Network Interface Card 3rd"
> +	# Fields of HW and management structures are little endian and will not
> +	# be explicitly converted

This is a PCIe device, users may plug it into any platform.
Please annotate the endian of the data structures and use appropriate
conversion helpers.

> +	depends on 64BIT && !CPU_BIG_ENDIAN
> +	depends on PCI_MSI && (X86 || ARM64)

Also allow COMPILE_TEST

> +	help
> +	  This driver supports HiNIC PCIE Ethernet cards.
> +	  To compile this driver as part of the kernel, choose Y here.
> +	  If unsure, choose N.
> +	  The default is N.
-- 
pw-bot: cr