netdev - Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241222081225.2543508-1-gur.stavi@huawei.com>
Date: Sun, 22 Dec 2024 10:12:25 +0200
From: Gur Stavi <gur.stavi@...wei.com>
To: <kuba@...nel.org>
CC: <andrew+netdev@...n.ch>, <cai.huoqing@...ux.dev>, <corbet@....net>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <gongfan1@...wei.com>,
	<guoxin09@...wei.com>, <gur.stavi@...wei.com>, <helgaas@...nel.org>,
	<horms@...nel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <meny.yossefi@...wei.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <shenchenyang1@...ilicon.com>,
	<shijing34@...wei.com>, <wulike1@...wei.com>, <zhoushuai28@...wei.com>
Subject: Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic

> On Thu, 19 Dec 2024 11:21:55 +0200 Gur Stavi wrote:
> > +config HINIC3
> > +	tristate "Huawei Intelligent Network Interface Card 3rd"
> > +	# Fields of HW and management structures are little endian and will not
> > +	# be explicitly converted
>
> This is a PCIe device, users may plug it into any platform.
> Please annotate the endian of the data structures and use appropriate
> conversion helpers.
>

This is basically saying that all drivers MUST support all architectures
which is not a currently documented requirement.
As I said before, both Amazon and Microsoft have this dependency.
They currently do not sell their HW so users cannot choose where to plug
it, but they could start selling it whenever they want and the driver will
remain the same.
The primary goal of this driver is for VMs in Huawei cloud, just like
Amazon and Microsoft. Whether users can actually buy it in the future is
unknown.

for the record, we did start at some point to change all integer members
in management structures to __leXX and use cpu_to_le and le_to_cpu.
There are hundreds of these and it made the code completely unreadable.

And since we do not plan to test the driver on POWER or ARM big endian I
really don't see the point.

> > +	depends on 64BIT && !CPU_BIG_ENDIAN
> > +	depends on PCI_MSI && (X86 || ARM64)
>
> Also allow COMPILE_TEST
>

Ack

> > +	help
> > +	  This driver supports HiNIC PCIE Ethernet cards.
> > +	  To compile this driver as part of the kernel, choose Y here.
> > +	  If unsure, choose N.
> > +	  The default is N.