lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202412210915.kToB6vsf-lkp@intel.com>
Date: Sat, 21 Dec 2024 09:54:05 +0800
From: kernel test robot <lkp@...el.com>
To: kernel@...neuler.org, "David S. Miller" <davem@...emloft.net>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: [openeuler:openEuler-1.0-LTS 1334/1334] net/core/sock.c:2813:33:
 sparse: sparse: incorrect type in assignment (different address spaces)

tree:   https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS
head:   02951ceaa6d546dfa0f741f52f6d47e0fb0ac7b4
commit: e6476c21447c4b17c47e476aade6facf050f31e8 [1334/1334] net: remove bogus RCU annotations on socket.wq
config: x86_64-randconfig-r112-20241218 (https://download.01.org/0day-ci/archive/20241221/202412210915.kToB6vsf-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241221/202412210915.kToB6vsf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412210915.kToB6vsf-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> net/core/sock.c:2813:33: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct socket_wq [noderef] __rcu *sk_wq @@     got struct socket_wq *wq @@
   net/core/sock.c:2813:33: sparse:     expected struct socket_wq [noderef] __rcu *sk_wq
   net/core/sock.c:2813:33: sparse:     got struct socket_wq *wq
   net/core/sock.c:1799:9: sparse: sparse: context imbalance in 'sk_clone_lock' - wrong count at exit
   net/core/sock.c:1803:6: sparse: sparse: context imbalance in 'sk_free_unlock_clone' - unexpected unlock
   net/core/sock.c:2922:6: sparse: sparse: context imbalance in 'lock_sock_fast' - different lock contexts for basic block
   net/core/sock.c:3397:13: sparse: sparse: context imbalance in 'proto_seq_start' - wrong count at exit
   net/core/sock.c:3409:13: sparse: sparse: context imbalance in 'proto_seq_stop' - wrong count at exit
   net/core/sock.o: warning: objtool: sock_warn_obsolete_bsdism()+0x31: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_mc_loop()+0x91: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_set_memalloc()+0x76: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: proto_register()+0x548: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: __sk_destruct()+0xd3: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: skb_set_owner_w()+0xf1: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: __sk_dst_check()+0xa2: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_common_release()+0x1c2: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: trace_sock_exceed_buf_limit()+0xf4: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_clear_memalloc()+0x7c: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: trace_sock_rcvqueue_full()+0xe6: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sock_def_wakeup()+0x10e: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_dst_check()+0x179: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_clone_lock()+0x92f: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sock_def_error_report()+0x14d: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sock_def_readable()+0x14d: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_alloc()+0x868: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sk_send_sigurg()+0x16f: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sock_def_write_space()+0x36c: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sock_setsockopt()+0xeb0: sibling call from callable instruction with modified stack frame
   net/core/sock.o: warning: objtool: sock_getsockopt()+0xab1: sibling call from callable instruction with modified stack frame

vim +2813 net/core/sock.c

^1da177e4c3f41 Linus Torvalds    2005-04-16  2795  
^1da177e4c3f41 Linus Torvalds    2005-04-16  2796  void sock_init_data(struct socket *sock, struct sock *sk)
^1da177e4c3f41 Linus Torvalds    2005-04-16  2797  {
581319c58600b5 Paolo Abeni       2017-03-09  2798  	sk_init_common(sk);
^1da177e4c3f41 Linus Torvalds    2005-04-16  2799  	sk->sk_send_head	=	NULL;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2800  
99767f278ccf74 Kees Cook         2017-10-16  2801  	timer_setup(&sk->sk_timer, NULL, 0);
^1da177e4c3f41 Linus Torvalds    2005-04-16  2802  
^1da177e4c3f41 Linus Torvalds    2005-04-16  2803  	sk->sk_allocation	=	GFP_KERNEL;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2804  	sk->sk_rcvbuf		=	sysctl_rmem_default;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2805  	sk->sk_sndbuf		=	sysctl_wmem_default;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2806  	sk->sk_state		=	TCP_CLOSE;
972692e0db9b0a David S. Miller   2008-06-17  2807  	sk_set_socket(sk, sock);
^1da177e4c3f41 Linus Torvalds    2005-04-16  2808  
^1da177e4c3f41 Linus Torvalds    2005-04-16  2809  	sock_set_flag(sk, SOCK_ZAPPED);
^1da177e4c3f41 Linus Torvalds    2005-04-16  2810  
e71a4783aae059 Stephen Hemminger 2007-04-10  2811  	if (sock) {
^1da177e4c3f41 Linus Torvalds    2005-04-16  2812  		sk->sk_type	=	sock->type;
43815482370c51 Eric Dumazet      2010-04-29 @2813  		sk->sk_wq	=	sock->wq;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2814  		sock->sk	=	sk;
86741ec25462e4 Lorenzo Colitti   2016-11-04  2815  		sk->sk_uid	=	SOCK_INODE(sock)->i_uid;
86741ec25462e4 Lorenzo Colitti   2016-11-04  2816  	} else {
43815482370c51 Eric Dumazet      2010-04-29  2817  		sk->sk_wq	=	NULL;
86741ec25462e4 Lorenzo Colitti   2016-11-04  2818  		sk->sk_uid	=	make_kuid(sock_net(sk)->user_ns, 0);
86741ec25462e4 Lorenzo Colitti   2016-11-04  2819  	}
^1da177e4c3f41 Linus Torvalds    2005-04-16  2820  
^1da177e4c3f41 Linus Torvalds    2005-04-16  2821  	rwlock_init(&sk->sk_callback_lock);
cdfbabfb2f0ce9 David Howells     2017-03-09  2822  	if (sk->sk_kern_sock)
cdfbabfb2f0ce9 David Howells     2017-03-09  2823  		lockdep_set_class_and_name(
cdfbabfb2f0ce9 David Howells     2017-03-09  2824  			&sk->sk_callback_lock,
cdfbabfb2f0ce9 David Howells     2017-03-09  2825  			af_kern_callback_keys + sk->sk_family,
cdfbabfb2f0ce9 David Howells     2017-03-09  2826  			af_family_kern_clock_key_strings[sk->sk_family]);
cdfbabfb2f0ce9 David Howells     2017-03-09  2827  	else
cdfbabfb2f0ce9 David Howells     2017-03-09  2828  		lockdep_set_class_and_name(
cdfbabfb2f0ce9 David Howells     2017-03-09  2829  			&sk->sk_callback_lock,
443aef0eddfa44 Peter Zijlstra    2007-07-19  2830  			af_callback_keys + sk->sk_family,
443aef0eddfa44 Peter Zijlstra    2007-07-19  2831  			af_family_clock_key_strings[sk->sk_family]);
^1da177e4c3f41 Linus Torvalds    2005-04-16  2832  
^1da177e4c3f41 Linus Torvalds    2005-04-16  2833  	sk->sk_state_change	=	sock_def_wakeup;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2834  	sk->sk_data_ready	=	sock_def_readable;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2835  	sk->sk_write_space	=	sock_def_write_space;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2836  	sk->sk_error_report	=	sock_def_error_report;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2837  	sk->sk_destruct		=	sock_def_destruct;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2838  
5640f7685831e0 Eric Dumazet      2012-09-23  2839  	sk->sk_frag.page	=	NULL;
5640f7685831e0 Eric Dumazet      2012-09-23  2840  	sk->sk_frag.offset	=	0;
ef64a54f6e5581 Pavel Emelyanov   2012-02-21  2841  	sk->sk_peek_off		=	-1;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2842  
109f6e39fa07c4 Eric W. Biederman 2010-06-13  2843  	sk->sk_peer_pid 	=	NULL;
109f6e39fa07c4 Eric W. Biederman 2010-06-13  2844  	sk->sk_peer_cred	=	NULL;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2845  	sk->sk_write_pending	=	0;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2846  	sk->sk_rcvlowat		=	1;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2847  	sk->sk_rcvtimeo		=	MAX_SCHEDULE_TIMEOUT;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2848  	sk->sk_sndtimeo		=	MAX_SCHEDULE_TIMEOUT;
^1da177e4c3f41 Linus Torvalds    2005-04-16  2849  
6c7c98bad4883a Paolo Abeni       2017-03-30  2850  	sk->sk_stamp = SK_DEFAULT_STAMP;
52267790ef52d7 Willem de Bruijn  2017-08-03  2851  	atomic_set(&sk->sk_zckey, 0);
^1da177e4c3f41 Linus Torvalds    2005-04-16  2852  

:::::: The code at line 2813 was first introduced by commit
:::::: 43815482370c510c569fd18edb57afcb0fa8cab6 net: sock_def_readable() and friends RCU conversion

:::::: TO: Eric Dumazet <eric.dumazet@...il.com>
:::::: CC: David S. Miller <davem@...emloft.net>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ