netdev - RE: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510820FA25DA47C6A7781F388002@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Sat, 21 Dec 2024 01:56:21 +0000
From: Wei Fang <wei.fang@....com>
To: Frank Li <frank.li@....com>
CC: "ast@...nel.org" <ast@...nel.org>, "daniel@...earbox.net"
	<daniel@...earbox.net>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "hawk@...nel.org" <hawk@...nel.org>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>, "andrii@...nel.org"
	<andrii@...nel.org>, "eddyz87@...il.com" <eddyz87@...il.com>,
	"mykolal@...com" <mykolal@...com>, "martin.lau@...ux.dev"
	<martin.lau@...ux.dev>, "song@...nel.org" <song@...nel.org>,
	"yonghong.song@...ux.dev" <yonghong.song@...ux.dev>, "kpsingh@...nel.org"
	<kpsingh@...nel.org>, "sdf@...ichev.me" <sdf@...ichev.me>,
	"haoluo@...gle.com" <haoluo@...gle.com>, "jolsa@...nel.org"
	<jolsa@...nel.org>, "shuah@...nel.org" <shuah@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to
 umem_config

> On Fri, Dec 20, 2024 at 05:18:06PM +0800, Wei Fang wrote:
> > The Tx metadata test has been broken since the commit d5e726d9143c
> ("xsk:
> > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len").
> 
> Nit:
> 
> Fixes tag already include this information.
> 
> The Tx metadata test has been broken becasue
> XDP_UMEM_TX_METADATA_LEN flag is not set ....
> 
> > Because
> > this change requires XDP_UMEM_TX_METADATA_LEN flag to be set,
> > otherwise xsk_buff_pool::tx_metadata_len will be initialized to 0,
> > which means that the driver cannot get Tx metadata and cannot execute
> > AF_XDP Tx metadata hooks.
> >
> > Fixes: d5e726d9143c ("xsk: Require XDP_UMEM_TX_METADATA_LEN to
> actuate
> > tx_metadata_len")
> > Signed-off-by: Wei Fang <wei.fang@....com>
> > ---
> >  tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c
> > b/tools/testing/selftests/bpf/xdp_hw_metadata.c
> > index 6f9956eed797..ad6c08dfd6c8 100644
> > --- a/tools/testing/selftests/bpf/xdp_hw_metadata.c
> > +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c
> > @@ -79,7 +79,7 @@ static int open_xsk(int ifindex, struct xsk *xsk, __u32
> queue_id)
> >  		.fill_size = XSK_RING_PROD__DEFAULT_NUM_DESCS,
> >  		.comp_size = XSK_RING_CONS__DEFAULT_NUM_DESCS,
> >  		.frame_size = XSK_UMEM__DEFAULT_FRAME_SIZE,
> > -		.flags = XSK_UMEM__DEFAULT_FLAGS,
> > +		.flags = XDP_UMEM_TX_METADATA_LEN,
> 
> look like "XSK_UMEM__DEFAULT_FLAGS | XDP_UMEM_TX_METADATA_LEN"
> 
> You clean other flags, does it what you what?
> 

XSK_UMEM__DEFAULT_FLAGS is 0, so no need anymore. The same patch
had been applied to bpf-next tree [1], so please ignore this one.

[1] https://lore.kernel.org/bpf/20241205044258.3155799-1-yoong.siang.song@intel.com/#t

> 
> >  		.tx_metadata_len = sizeof(struct xsk_tx_metadata),
> >  	};
> >  	__u32 idx = 0;
> > --
> > 2.34.1
> >