netdev - Re: [PATCH 26/29] net/tls: use the new scatterwalk functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241223124431.1d34888f@kernel.org>
Date: Mon, 23 Dec 2024 12:44:31 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, Boris Pismenny <borisp@...dia.com>, John
 Fastabend <john.fastabend@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 26/29] net/tls: use the new scatterwalk functions

On Mon, 23 Dec 2024 11:42:49 -0800 Eric Biggers wrote:
> > Acked-by: Jakub Kicinski <kuba@...nel.org>  
> 
> Thanks.  FYI I will need to update this patch in the next version, as I did not
> take into consideration what chain_to_walk() is doing.  This code seems to be a
> bit unique in how it is using the scatterwalk functions.
> 
> Also I think the second paragraph of my commit message is wrong, as the calls to
> scatterwalk_done() in tls_enc_records() are the ones I thought were missing.

netdev@ only got CCed on this one patch so TBH I have trusted 
the conversion :(

FWIW tls has a relatively solid selftest:
tools/testing/selftests/net/tls.c