netdev - Re: [PATCH 26/29] net/tls: use the new scatterwalk functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241223194249.GB2032@quark.localdomain>
Date: Mon, 23 Dec 2024 11:42:49 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: linux-crypto@...r.kernel.org, Boris Pismenny <borisp@...dia.com>,
	John Fastabend <john.fastabend@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 26/29] net/tls: use the new scatterwalk functions

On Mon, Dec 23, 2024 at 07:48:25AM -0800, Jakub Kicinski wrote:
> On Sat, 21 Dec 2024 01:10:53 -0800 Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > Replace calls to the deprecated function scatterwalk_copychunks() with
> > memcpy_from_scatterwalk(), memcpy_to_scatterwalk(), or
> > scatterwalk_skip() as appropriate.
> > 
> > The new functions behave more as expected and eliminate the need to call
> > scatterwalk_done() or scatterwalk_pagedone().  This was not always being
> > done when needed, and therefore the old code appears to have also had a
> > bug where the dcache of the destination page(s) was not always being
> > flushed on architectures that need that.
> > 
> > Cc: Boris Pismenny <borisp@...dia.com>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: John Fastabend <john.fastabend@...il.com>
> > Cc: netdev@...r.kernel.org
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> 
> Acked-by: Jakub Kicinski <kuba@...nel.org>

Thanks.  FYI I will need to update this patch in the next version, as I did not
take into consideration what chain_to_walk() is doing.  This code seems to be a
bit unique in how it is using the scatterwalk functions.

Also I think the second paragraph of my commit message is wrong, as the calls to
scatterwalk_done() in tls_enc_records() are the ones I thought were missing.

- Eric