netdev - Re: [PATCH 26/29] net/tls: use the new scatterwalk functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241223074825.7c4c74a0@kernel.org>
Date: Mon, 23 Dec 2024 07:48:25 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, Boris Pismenny <borisp@...dia.com>, John
 Fastabend <john.fastabend@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 26/29] net/tls: use the new scatterwalk functions

On Sat, 21 Dec 2024 01:10:53 -0800 Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Replace calls to the deprecated function scatterwalk_copychunks() with
> memcpy_from_scatterwalk(), memcpy_to_scatterwalk(), or
> scatterwalk_skip() as appropriate.
> 
> The new functions behave more as expected and eliminate the need to call
> scatterwalk_done() or scatterwalk_pagedone().  This was not always being
> done when needed, and therefore the old code appears to have also had a
> bug where the dcache of the destination page(s) was not always being
> flushed on architectures that need that.
> 
> Cc: Boris Pismenny <borisp@...dia.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Acked-by: Jakub Kicinski <kuba@...nel.org>