netdev - RE: [Intel-wired-lan] [PATCH iwl-next v2 1/5] ice: use rd32_poll_timeout_atomic in ice_read_phy_tstamp_ll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62410F84EDA48194F475D7FC8B022@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Mon, 23 Dec 2024 17:16:40 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Nadezhdin, Anton" <anton.nadezhdin@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "richardcochran@...il.com"
	<richardcochran@...il.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Kolacinski, Karol" <karol.kolacinski@...el.com>, "Olech, Milena"
	<milena.olech@...el.com>, "Nadezhdin, Anton" <anton.nadezhdin@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2 1/5] ice: use
 rd32_poll_timeout_atomic in ice_read_phy_tstamp_ll_e810

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Anton Nadezhdin
> Sent: 16 December 2024 20:23
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; richardcochran@...il.com; Keller, Jacob E <jacob.e.keller@...el.com>; Kolacinski, Karol <karol.kolacinski@...el.com>; Olech, Milena <milena.olech@...el.com>; Nadezhdin, Anton <anton.nadezhdin@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/5] ice: use rd32_poll_timeout_atomic in ice_read_phy_tstamp_ll_e810
>
> From: Jacob Keller <jacob.e.keller@...el.com>
>
> The ice_read_phy_tstamp_ll_e810 function repeatedly reads the PF_SB_ATQBAL register until the TS_LL_READ_TS bit is cleared. This is a perfect candidate for using rd32_poll_timeout. However, the default implementation uses a sleep-based wait.
>
> Add a new rd32_poll_timeout_atomic macro which is based on the non-sleeping read_poll_timeout_atomic implementation. Use this to replace the loop reading in the ice_read_phy_tstamp_ll_e810 function.
>
> This will also be used in the future when low latency PHY timer updates are supported.
>
> Co-developed-by: Karol Kolacinski <karol.kolacinski@...el.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Milena Olech <milena.olech@...el.com>
> Signed-off-by: Anton Nadezhdin <anton.nadezhdin@...el.com>
> ---
> drivers/net/ethernet/intel/ice/ice_osdep.h  |  3 +++  drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 30 +++++++++------------  drivers/net/ethernet/intel/ice/ice_ptp_hw.h |  2 +-
> 3 files changed, 17 insertions(+), 18 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)