netdev - RE: [Intel-wired-lan] [PATCH iwl-next v4] ice: add fw and port health reporters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB624145EE61E5BEEE1DECAF2C8B022@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Mon, 23 Dec 2024 17:18:02 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Knitter, Konrad" <konrad.knitter@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "brett.creeley@....com"
	<brett.creeley@....com>, "marcin.szycik@...ux.intel.com"
	<marcin.szycik@...ux.intel.com>, "Knitter, Konrad" <konrad.knitter@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v4] ice: add fw and port health
 reporters

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Konrad Knitter
> Sent: 11 December 2024 16:34
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; netdev@...r.kernel.org; kuba@...nel.org; pabeni@...hat.com; edumazet@...gle.com; davem@...emloft.net; andrew+netdev@...n.ch; brett.creeley@....com; marcin.szycik@...ux.intel.com; Knitter, Konrad <konrad.knitter@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v4] ice: add fw and port health reporters
>
> Firmware generates events for global events or port specific events.
>
> Driver shall subscribe for health status events from firmware on supported FW versions >= 1.7.6.
> Driver shall expose those under specific health reporter, two new reporters are introduced:
> - FW health reporter shall represent global events (problems with the image, recovery mode);
> - Port health reporter shall represent port-specific events (module failure).
>
> Firmware only reports problems when those are detected, it does not store active fault list.
> Driver will hold only last global and last port-specific event.
> Driver will report all events via devlink health report, so in case of multiple events of the same source they can be reviewed using devlink autodump feature.
> 
> $ devlink health
>
> pci/0000:b1:00.3:
> reporter fw
>   state healthy error 0 recover 0 auto_dump true
> reporter port
>    state error error 1 recover 0 last_dump_date 2024-03-17
>	last_dump_time 09:29:29 auto_dump true
>
> $ devlink health diagnose pci/0000:b1:00.3 reporter port
>
> Syndrome: 262
> Description: Module is not present.
> Possible Solution: Check that the module is inserted correctly.
> Port Number: 0
>
> Tested on Intel Corporation Ethernet Controller E810-C for SFP
>
> Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> Co-developed-by: Sharon Haroni <sharon.haroni@...el.com>
> Signed-off-by: Sharon Haroni <sharon.haroni@...el.com>
> Co-developed-by: Nicholas Nunley <nicholas.d.nunley@...el.com>
> Signed-off-by: Nicholas Nunley <nicholas.d.nunley@...el.com>
> Co-developed-by: Brett Creeley <brett.creeley@...el.com>
> Signed-off-by: Brett Creeley <brett.creeley@...el.com>
> Signed-off-by: Konrad Knitter <konrad.knitter@...el.com>
>
> ---
> v4: Extended documentation to ice_is_fw_health_report_supported.
> Comparing host byte order event_source.
> v3: Changed patch title to add health reporters. Style fixes.
> https://lore.kernel.org/intel-wired-lan/20241209093204.173817-1-konrad.knitter@intel.com/T/#u
> v2: Removal of __VA_OPS__ usage. Style fixes.
> https://lore.kernel.org/intel-wired-lan/20241209111359.GA2581@kernel.org/T/#t
> v1: Initial version
> https://lore.kernel.org/intel-wired-lan/20241118104810.477794-1-konrad.knitter@intel.com/#t
>
> Depends-on: https://lore.kernel.org/netdev/20240930133724.610512-1-przemyslaw.kitszel@intel.com/T/
> ---
> .../net/ethernet/intel/ice/devlink/health.c   | 295 +++++++++++++++++-
> .../net/ethernet/intel/ice/devlink/health.h   |  14 +-
> .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  87 ++++++
> drivers/net/ethernet/intel/ice/ice_common.c   |  38 +++
> drivers/net/ethernet/intel/ice/ice_common.h   |   2 +
> drivers/net/ethernet/intel/ice/ice_main.c     |   3 +
> drivers/net/ethernet/intel/ice/ice_type.h     |   5 +
> 7 files changed, 436 insertions(+), 8 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)