netdev - Re: [PATCH v4 10/11] cxl/pmem: Replace match_nvdimm_bridge() with API device_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d7531da-5ae9-4c31-93c6-f2bca4c2d814@icloud.com>
Date: Tue, 24 Dec 2024 20:58:38 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Uwe Kleine-König <ukleinek@...nel.org>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 Thomas Weißschuh <thomas@...ch.de>,
 linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev,
 linux-sound@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-block@...r.kernel.org, linux-cxl@...r.kernel.org,
 linux1394-devel@...ts.sourceforge.net, arm-scmi@...r.kernel.org,
 linux-efi@...r.kernel.org, linux-gpio@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
 linux-hwmon@...r.kernel.org, linux-media@...r.kernel.org,
 linux-pwm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 linux-scsi@...r.kernel.org, linux-usb@...r.kernel.org,
 linux-serial@...r.kernel.org, netdev@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>,
 Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH v4 10/11] cxl/pmem: Replace match_nvdimm_bridge() with API
 device_match_type()

On 2024/12/24 04:48, Jonathan Cameron wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> Static match_nvdimm_bridge(), as matching function of device_find_child()
>> matches a device with device type @cxl_nvdimm_bridge_type, and its task
>> can be simplified by the recently introduced API device_match_type().
>>
>> Replace match_nvdimm_bridge() usage with device_match_type().
>>
>> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> I don't see any uses of is_cxl_nvdimm_bridge() other than this one
> Drop that as well?
> 
will add a optional patch to drop is_cxl_nvdimm_bridge() in next revision.

> This one is a bit of a trade off because the way is_cxl_nvdimm_bridge()
> is identified is kind of an internal detail, but it's been true for a long
> time so I'm fine with this change.
> 
> Jonathan