| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241224-const_dfc_done-v5-0-6623037414d4@quicinc.com>
Date: Tue, 24 Dec 2024 21:04:59 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Uwe Kleine-König <ukleinek@...nel.org>,
James Bottomley <James.Bottomley@...senPartnership.com>,
Thomas Weißschuh <thomas@...ch.de>,
Zijun Hu <zijun_hu@...oud.com>, linux-kernel@...r.kernel.org,
nvdimm@...ts.linux.dev, linux-sound@...r.kernel.org,
sparclinux@...r.kernel.org, linux-block@...r.kernel.org,
linux-cxl@...r.kernel.org, linux1394-devel@...ts.sourceforge.net,
arm-scmi@...r.kernel.org, linux-efi@...r.kernel.org,
linux-gpio@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org, linux-hwmon@...r.kernel.org,
linux-media@...r.kernel.org, linux-pwm@...r.kernel.org,
linux-remoteproc@...r.kernel.org, linux-scsi@...r.kernel.org,
linux-usb@...r.kernel.org, linux-serial@...r.kernel.org,
netdev@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>,
Alison Schofield <alison.schofield@...el.com>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Takashi Sakamoto <o-takashi@...amocchi.jp>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: [PATCH v5 00/12] driver core: Constify API device_find_child()
This patch series is to constify the following API:
struct device *device_find_child(struct device *dev, void *data,
int (*match)(struct device *dev, void *data));
To :
struct device *device_find_child(struct device *dev, const void *data,
device_match_t match);
typedef int (*device_match_t)(struct device *dev, const void *data);
Why to constify the API?
- Protect caller's match data @*data which is for comparison and lookup
and the API does not actually need to modify @*data.
- Make the API's parameters (@match)() and @data have the same type as
all of other device finding APIs (bus|class|driver)_find_device().
- All kinds of existing device matching functions can be directly taken
as the API's argument, they were exported by driver core.
What to do?
- Patches [1/11, 3/11] prepare for constifying the API.
- Patch 4/11 constifies the API and adapt for its various subsystem usages.
- Remaining do cleanup for several usages with benefits brought above.
---
Changes in v5:
- Correct tile and commit messages based on Jonathan comments.
- Add one more optional patch 11/12 based on Jonathan proposal.
- Link to v4: https://lore.kernel.org/r/20241211-const_dfc_done-v4-0-583cc60329df@quicinc.com
Changes in v4:
- Correct title and commit messages according to review comments
- Link to v3: https://lore.kernel.org/r/20241205-const_dfc_done-v3-0-1611f1486b5a@quicinc.com
Changes in v3:
- Solve build broken issue by squashing changes of various subsystem.
- Reduce recipients to try to send out full patch serial.
- Correct tiles and commit messages.
- Link to v2: https://lore.kernel.org/all/20241203-const_dfc_done-v2-0-7436a98c497f@quicinc.com
Changes in v2:
- Series v1 have no code review comments and are posted a long time ago, so may ignore differences.
- Link to v1: https://lore.kernel.org/r/20240811-const_dfc_done-v1-0-9d85e3f943cb@quicinc.com
- Motivation link: https://lore.kernel.org/lkml/917359cc-a421-41dd-93f4-d28937fe2325@icloud.com
---
Zijun Hu (12):
libnvdimm: Replace namespace_match() with device_find_child_by_name()
slimbus: core: Constify slim_eaddr_equal()
bus: fsl-mc: Constify fsl_mc_device_match()
driver core: Constify API device_find_child() and adapt for various usages
driver core: Simplify API device_find_child_by_name() implementation
driver core: Remove match_any()
slimbus: core: Remove of_slim_match_dev()
gpio: sim: Remove gpio_sim_dev_match_fwnode()
driver core: Introduce an device matching API device_match_type()
cxl/pmem: Replace match_nvdimm_bridge() with API device_match_type()
cxl/pmem: Remove is_cxl_nvdimm_bridge()
usb: typec: class: Remove both cable_match() and partner_match()
arch/sparc/kernel/vio.c | 6 +++---
drivers/base/core.c | 30 ++++++++++--------------------
drivers/block/sunvdc.c | 6 +++---
drivers/bus/fsl-mc/dprc-driver.c | 8 ++++----
drivers/cxl/core/pci.c | 4 ++--
drivers/cxl/core/pmem.c | 15 +++------------
drivers/cxl/core/region.c | 21 ++++++++++++---------
drivers/cxl/cxl.h | 1 -
drivers/firewire/core-device.c | 4 ++--
drivers/firmware/arm_scmi/bus.c | 4 ++--
drivers/firmware/efi/dev-path-parser.c | 4 ++--
drivers/gpio/gpio-sim.c | 7 +------
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
drivers/hwmon/hwmon.c | 2 +-
drivers/media/pci/mgb4/mgb4_core.c | 4 ++--
drivers/nvdimm/bus.c | 2 +-
drivers/nvdimm/claim.c | 9 +--------
drivers/pwm/core.c | 2 +-
drivers/rpmsg/rpmsg_core.c | 4 ++--
drivers/scsi/qla4xxx/ql4_os.c | 3 ++-
drivers/scsi/scsi_transport_iscsi.c | 10 +++++-----
drivers/slimbus/core.c | 17 +++++------------
drivers/thunderbolt/retimer.c | 2 +-
drivers/thunderbolt/xdomain.c | 2 +-
drivers/tty/serial/serial_core.c | 4 ++--
drivers/usb/typec/class.c | 31 ++++++++++++++-----------------
include/linux/device.h | 4 ++--
include/linux/device/bus.h | 1 +
include/scsi/scsi_transport_iscsi.h | 4 ++--
net/dsa/dsa.c | 2 +-
tools/testing/cxl/test/cxl.c | 2 +-
31 files changed, 90 insertions(+), 127 deletions(-)
---
base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
change-id: 20241201-const_dfc_done-aaec71e3bbea
Best regards,
--
Zijun Hu <quic_zijuhu@...cinc.com>
Powered by blists - more mailing lists