netdev - Re: [PATCH v2 08/14] net-next/yunsilicon: Add ethernet interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9409fd96-6266-4d8a-b8e9-cc274777cd2c@lunn.ch>
Date: Mon, 30 Dec 2024 16:29:47 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Xin Tian <tianx@...silicon.com>
Cc: netdev@...r.kernel.org, andrew+netdev@...n.ch, kuba@...nel.org,
	pabeni@...hat.com, edumazet@...gle.com, davem@...emloft.net,
	jeff.johnson@....qualcomm.com, przemyslaw.kitszel@...el.com,
	weihg@...silicon.com, wanry@...silicon.com
Subject: Re: [PATCH v2 08/14] net-next/yunsilicon: Add ethernet interface

> +static void *xsc_eth_add(struct xsc_core_device *xdev)
> +{
> +	adapter->dev = &adapter->pdev->dev;
> +	adapter->xdev = (void *)xdev;

> +	xdev->netdev = (void *)netdev;

Why have casts to void *? There are clear type here, rather than it
being a cookie passed via an abstract interface.

	Andrew