netdev - Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241230192326.384fd21d@kernel.org>
Date: Mon, 30 Dec 2024 19:23:26 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gur Stavi <gur.stavi@...wei.com>
Cc: <andrew+netdev@...n.ch>, <cai.huoqing@...ux.dev>, <corbet@....net>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <gongfan1@...wei.com>,
 <guoxin09@...wei.com>, <helgaas@...nel.org>, <horms@...nel.org>,
 <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <meny.yossefi@...wei.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
 <shenchenyang1@...ilicon.com>, <shijing34@...wei.com>,
 <wulike1@...wei.com>, <zhoushuai28@...wei.com>
Subject: Re: [PATCH net-next v01 1/1] hinic3: module initialization and
 tx/rx logic

On Mon, 30 Dec 2024 16:14:35 +0200 Gur Stavi wrote:
> > > The most popular combination in the last 3 decades was little endian
> > > CPUs with big endian device interfaces. Endianity conversion was a
> > > necessity and therefore endian annotation became standard practice.
> > > But it was never symmetric, conversion to/from BE was more common than
> > > conversion to/from LE.
> > >
> > > As the pendulum moved from horizontal market to vertical market and major
> > > companies started to develop both hw and sw, the hw engineers transformed
> > > proprietary parts of the interface to little endian to save extra work in
> > > the sw. AWS did it. Azure did it. Huawei did it. These vertical companies
> > > do not care about endianity of CPUs they do not use.
> > > This is not "corporate verbiage" this is a real market shift.  
> >
> > Don't misquote me. You did it in your previous reply, now you're doing
> > it again.
> >
> > If you don't understand what I'm saying you can ask for clarifications.
> 
> We studied previous submissions and followed their example.
> Were the maintainers wrong to approve Amazon and Microsoft drivers?

It's not a right or wrong question, more a cost/benefit question.
I'm not sure the community benefits from merging every single company's
paravirt driver, when virtio exists. I'd say having those drivers
upstream is somewhere around neutral.

BTW very often guidance for new drivers is set by problems with already
merged drivers. Not that it's necessarily the case here, just sharing
some general knowledge about the upstream process.

> I don't understand what the problem is. Please clarify.

Primarily the fact that you keep arguing as if joining the community
was done by winning a fight. If annotating HW structures with endian
is beyond your / your teams capabilities, that's okay, just replace
the "will not be converted" with "are currently not converted" in 
the comment.

For your reference here are the development stats showing that
Huawei is the biggest net-taker of code reviews in networking:
https://lore.kernel.org/all/20241119191608.514ea226@kernel.org/