netdev - Re: [PATCH net-next 3/4] net: wangxun: Add watchdog task for PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3ejljjy1QqsRxox@hoboy.vegasvil.org>
Date: Fri, 3 Jan 2025 00:45:54 -0800
From: Richard Cochran <richardcochran@...il.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Jiawen Wu <jiawenwu@...stnetic.com>, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux@...linux.org.uk, horms@...nel.org,
	jacob.e.keller@...el.com, netdev@...r.kernel.org,
	mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next 3/4] net: wangxun: Add watchdog task for PTP
 clock

On Thu, Jan 02, 2025 at 05:53:17PM +0000, Vadim Fedorenko wrote:
> On 02/01/2025 10:30, Jiawen Wu wrote:
> > Implement watchdog task to detect SYSTIME overflow and error cases of
> > Rx/Tx timestamp.
> 
> Commit message doesn't look easy to understand, but according to the
> comment in the code, watchdog is checking for timecounter overflows.
> For PTP use case it's better to use .do_aux_work of struct ptp_clock_info.
> It will simplify a lot of code and will setup a worker in a dedicated
> queue which can be prioritized separately.

+1

Thanks,
Richard