netdev - RE: [PATCH net-next 2/4] net: wangxun: Implement get_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <032601db5fe3$9b96d550$d2c47ff0$@trustnetic.com>
Date: Mon, 6 Jan 2025 10:35:10 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Vadim Fedorenko'" <vadim.fedorenko@...ux.dev>,
	<andrew+netdev@...n.ch>,
	<davem@...emloft.net>,
	<edumazet@...gle.com>,
	<kuba@...nel.org>,
	<pabeni@...hat.com>,
	<richardcochran@...il.com>,
	<linux@...linux.org.uk>,
	<horms@...nel.org>,
	<jacob.e.keller@...el.com>,
	<netdev@...r.kernel.org>
Cc: <mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next 2/4] net: wangxun: Implement get_ts_info

> > +int wx_get_ts_info(struct net_device *dev,
> > +		   struct kernel_ethtool_ts_info *info)
> > +{
> > +	struct wx *wx = netdev_priv(dev);
> > +
> > +	info->rx_filters = BIT(HWTSTAMP_FILTER_NONE) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V1_L4_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L2_EVENT) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L4_EVENT) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L2_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L4_SYNC) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L2_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ) |
> > +			   BIT(HWTSTAMP_FILTER_PTP_V2_EVENT);
> > +
> > +	info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> > +				SOF_TIMESTAMPING_RX_SOFTWARE |
> 
> SOF_TIMESTAMPING_RX_SOFTWARE is now moved to core networking and there
> is no need to report it from driver
> 
> > +				SOF_TIMESTAMPING_SOFTWARE |
> 
> SOF_TIMESTAMPING_SOFTWARE means "software-system-clock". What kind of
> software clock is provided by the driver?

I think I should remove it.