netdev - Re: [PATCH net-next v4 25/27] dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rva5vyuksnw64j7hbgdjp2n4qw22a7niw4oc66dyaz5ndaa7ja@u6z4mavekjsw>
Date: Sat, 4 Jan 2025 10:52:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <o.rempel@...gutronix.de>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Jonathan Corbet <corbet@....net>, Donald Hunter <donald.hunter@...il.com>, 
	Rob Herring <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, 
	Simon Horman <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, 
	Russell King <linux@...linux.org.uk>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-doc@...r.kernel.org, 
	Kyle Swenson <kyle.swenson@....tech>, Dent Project <dentproject@...uxfoundation.org>, 
	kernel@...gutronix.de, Maxime Chevallier <maxime.chevallier@...tlin.com>, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v4 25/27] dt-bindings: net: pse-pd:
 microchip,pd692x0: Add manager regulator supply

On Fri, Jan 03, 2025 at 10:13:14PM +0100, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> 
> This patch adds the regulator supply parameter of the managers.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> It updates also the example as the regulator supply of the PSE PIs
> should be the managers itself and not an external regulator.
> 
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---
> 
> Changes in v3:
> - New patch
> ---
>  .../devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml    | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
> index fd4244fceced..0dc0da32576b 100644
> --- a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
> +++ b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
> @@ -68,6 +68,9 @@ properties:
>            "#size-cells":
>              const: 0
>  
> +          vmain-supply:
> +            description: Regulator power supply for the PD69208X manager.

s/Regulator//
Keep it simple, no need to state obvious. What is not obvious here is
why there are no main device supplies (VDD, VDDA).

And what about VAUX5 and VAUX3P3? So basically the description is not
only redundant but actually incorrect because it suggests it is entire
supply, while there are others.

> +
>          patternProperties:
>            '^port@[0-7]$':
>              type: object
> @@ -106,10 +109,11 @@ examples:
>            #address-cells = <1>;
>            #size-cells = <0>;
>  
> -          manager@0 {
> +          manager0: manager@0 {
>              reg = <0>;
>              #address-cells = <1>;
>              #size-cells = <0>;
> +            vmain-supply = <&pse1_supply>;
>  
>              phys0: port@0 {
>                reg = <0>;
> @@ -128,7 +132,7 @@ examples:
>              };
>            };
>  
> -          manager@1 {
> +          manager1: manager@1 {

Not used.

Best regards,
Krzysztof