netdev - Re: [PATCH 1/2] rt2x00: Remove unusued value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250104103753.GA2228@wp.pl>
Date: Sat, 4 Jan 2025 11:37:53 +0100
From: Stanislaw Gruszka <stf_xl@...pl>
To: Ariel Otilibili-Anieli <Ariel.Otilibili-Anieli@...ecom.fr>
Cc: Daniel Golle <daniel@...rotopia.org>, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
	Tomislav Požega <pozega.tomislav@...il.com>
Subject: Re: [PATCH 1/2] rt2x00: Remove unusued value

Hi

On Fri, Jan 03, 2025 at 02:39:21PM +0100, Ariel Otilibili-Anieli wrote:
> On Friday, January 03, 2025 14:10 CET, Stanislaw Gruszka <stf_xl@...pl> wrote:
> 
> > On Fri, Jan 03, 2025 at 11:40:52AM +0000, Daniel Golle wrote:
> > > On Fri, Jan 03, 2025 at 09:55:40AM +0100, Stanislaw Gruszka wrote:
> > > 
> > > I agree with the likely intention here, however, the vendor driver
> > > also comes with the dead code, see
> > > https://github.com/lixuande/rt2860v2/blob/master/files/rt2860v2/common/cmm_rf_cal.c#L2690
> > > 
> > > So this is certainly a bug in the vendor driver as well which got ported
> > > bug-by-bug to rt2x00... Not sure what is the best thing to do in this
> > > case.
> > 
> > As this was already tested and match vendor driver I would prefer
> > not to change behavior even if it looks suspicious.
> 
> Thanks for having looked into this; I much appreciate your feedback.
> 
> From what you two said, I understand that the patch should remove the duplicate code, and not change the logic behind.
> 
> Is this right?

Yes. 

Regards
Stanislaw
> 
> If so; then, I have nothing else to do.
> > 
> > Regards
> > Stanislaw
> >
>