netdev - Re: [PATCH v2] net/mlx5: Fix variable not being completed when function returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250109082915.3b011415@kernel.org>
Date: Thu, 9 Jan 2025 08:29:15 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: Chenguang Zhao <zhaochenguang@...inos.cn>, Saeed Mahameed
 <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Tariq Toukan
 <tariqt@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Moshe Shemesh <moshe@...dia.com>,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH v2] net/mlx5: Fix variable not being completed when
 function returns

On Thu, 9 Jan 2025 15:25:36 +0200 Tariq Toukan wrote:
> >       mlx5_core 0000:01:00.0: cmd_work_handler:877:(pid 3880418): failed to allocate command entry
> >       INFO: task kworker/13:2:4055883 blocked for more than 120 seconds.
> >             Not tainted 4.19.90-25.44.v2101.ky10.aarch64 #1
> >       "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> >       kworker/13:2    D    0 4055883      2 0x00000228
> >       Workqueue: events mlx5e_tx_dim_work [mlx5_core]
> >       Call trace:
> >        __switch_to+0xe8/0x150
> >        __schedule+0x2a8/0x9b8
> >        schedule+0x2c/0x88
> >        schedule_timeout+0x204/0x478
> >        wait_for_common+0x154/0x250
> >        wait_for_completion+0x28/0x38
> >        cmd_exec+0x7a0/0xa00 [mlx5_core]
> >        mlx5_cmd_exec+0x54/0x80 [mlx5_core]
> >        mlx5_core_modify_cq+0x6c/0x80 [mlx5_core]
> >        mlx5_core_modify_cq_moderation+0xa0/0xb8 [mlx5_core]
> >        mlx5e_tx_dim_work+0x54/0x68 [mlx5_core]
> >        process_one_work+0x1b0/0x448
> >        worker_thread+0x54/0x468
> >        kthread+0x134/0x138
> >        ret_from_fork+0x10/0x18
> > 
> >      Fixes: 485d65e13571 ("net/mlx5: Add a timeout to acquire the command queue semaphore")  
> 
> Also for the Fixes tag.
> 
> Other than that:
> Acked-by: Tariq Toukan <tariqt@...dia.com>

rewritten the commit message and applied, thanks!