netdev - Re: [PATCH net v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: 
 <173644022981.1439025.10283041006205138071.git-patchwork-notify@kernel.org>
Date: Thu, 09 Jan 2025 16:30:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Toke Høiland-Jørgensen <toke@...hat.com>@codeaurora.org
Cc: toke@...e.dk, jhs@...atatu.com, xiyou.wangcong@...il.com,
 jiri@...nulli.us, pabeni@...hat.com,
 syzbot+f63600d288bfb7057424@...kaller.appspotmail.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, horms@...nel.org,
 cake@...ts.bufferbloat.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] sched: sch_cake: add bounds checks to host bulk flow
 fairness counts

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Tue,  7 Jan 2025 13:01:05 +0100 you wrote:
> Even though we fixed a logic error in the commit cited below, syzbot
> still managed to trigger an underflow of the per-host bulk flow
> counters, leading to an out of bounds memory access.
> 
> To avoid any such logic errors causing out of bounds memory accesses,
> this commit factors out all accesses to the per-host bulk flow counters
> to a series of helpers that perform bounds-checking before any
> increments and decrements. This also has the benefit of improving
> readability by moving the conditional checks for the flow mode into
> these helpers, instead of having them spread out throughout the
> code (which was the cause of the original logic error).
> 
> [...]

Here is the summary with links:
  - [net,v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts
    https://git.kernel.org/netdev/net/c/737d4d91d35b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html