netdev - Re: [PATCH net] net: phy: Kconfig: Fix error related to undefined reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250109200247.GR7706@kernel.org>
Date: Thu, 9 Jan 2025 20:02:47 +0000
From: Simon Horman <horms@...nel.org>
To: Divya Koppera <divya.koppera@...rochip.com>
Cc: andrew@...n.ch, arun.ramadoss@...rochip.com,
	UNGLinuxDriver@...rochip.com, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, richardcochran@...il.com,
	vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net] net: phy: Kconfig: Fix error related to undefined
 reference

On Thu, Jan 09, 2025 at 05:44:32PM +0530, Divya Koppera wrote:
> When microchip_t1_phy is built in and phyptp is module
> facing undefined reference issue. This get fixed when
> microchip_t1_phy made dependent on PTP_1588_CLOCK_OPTIONAL.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202501090604.YEoJXCXi-lkp@intel.com
> Fixes: fa51199c5f34 ("net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys")
> Signed-off-by: Divya Koppera <divya.koppera@...rochip.com>

Hi Divya,

I think that this patch should be targeted at net-next, where
the problem seems to manifest, rather than net where it does not.
Likewise, this patch applies to net-next, but not net.

Also, I think the prefix for the patch should be "net: phy: microchip_t1".
And perhaps the following subject is a bit more descriptive.

	[PATCH net-next] net: phy: microchip_t1: depend on PTP_1588_CLOCK_OPTIONAL

As for the code change itself, it looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org> # build-tested

-- 
pw-bot: changes-requested