netdev - Re: [PATCH net-next v2 08/14] net: ethernet: qualcomm: Initialize PPE service code settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50a42c90-bbe7-4bdd-90dd-c8bfe4d4051d@quicinc.com>
Date: Fri, 10 Jan 2025 23:36:58 +0800
From: Jie Luo <quic_luoj@...cinc.com>
To: Simon Horman <horms@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Lei Wei <quic_leiwei@...cinc.com>,
        Suruchi Agarwal
	<quic_suruchia@...cinc.com>,
        Pavithra R <quic_pavir@...cinc.com>,
        "Jonathan
 Corbet" <corbet@....net>, Kees Cook <kees@...nel.org>,
        "Gustavo A. R. Silva"
	<gustavoars@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
        <quic_kkumarcs@...cinc.com>, <quic_linchen@...cinc.com>,
        <srinivas.kandagatla@...aro.org>, <bartosz.golaszewski@...aro.org>,
        <john@...ozen.org>
Subject: Re: [PATCH net-next v2 08/14] net: ethernet: qualcomm: Initialize PPE
 service code settings



On 1/10/2025 1:58 AM, Simon Horman wrote:
> On Wed, Jan 08, 2025 at 09:47:15PM +0800, Luo Jie wrote:
>> PPE service code is a special code (0-255) that is defined by PPE for
>> PPE's packet processing stages, as per the network functions required
>> for the packet.
>>
>> For packet being sent out by ARM cores on Ethernet ports, The service
>> code 1 is used as the default service code. This service code is used
>> to bypass most of packet processing stages of the PPE before the packet
>> transmitted out PPE port, since the software network stack has already
>> processed the packet.
>>
>> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>
> 
> ...
> 
>> diff --git a/drivers/net/ethernet/qualcomm/ppe/ppe_config.h b/drivers/net/ethernet/qualcomm/ppe/ppe_config.h
> 
> ...
> 
>> +/**
>> + * struct ppe_sc_bypss - PPE service bypass bitmaps
> 
> nit: struct ppe_sc_bypass

OK. Will correct it.

> 
>> + * @ingress: Bitmap of features that can be bypassed on the ingress packet.
>> + * @egress: Bitmap of features that can be bypassed on the egress packet.
>> + * @counter: Bitmap of features that can be bypassed on the counter type.
>> + * @tunnel: Bitmap of features that can be bypassed on the tunnel packet.
>> + */
>> +struct ppe_sc_bypass {
>> +	DECLARE_BITMAP(ingress, PPE_SC_BYPASS_INGRESS_SIZE);
>> +	DECLARE_BITMAP(egress, PPE_SC_BYPASS_EGRESS_SIZE);
>> +	DECLARE_BITMAP(counter, PPE_SC_BYPASS_COUNTER_SIZE);
>> +	DECLARE_BITMAP(tunnel, PPE_SC_BYPASS_TUNNEL_SIZE);
>> +};
> 
> ...