netdev - Re: [PATCH v3] net: wwan: iosm: Fix hibernation by re-binding the driver around it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44a21765-1283-4e79-b24a-fb672399250d@redhat.com>
Date: Tue, 14 Jan 2025 09:49:55 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
 M Chetan Kumar <m.chetan.kumar@...el.com>,
 Loic Poulain <loic.poulain@...aro.org>,
 Sergey Ryazanov <ryazanov.s.a@...il.com>,
 Johannes Berg <johannes@...solutions.net>,
 Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>,
 netdev@...r.kernel.org, linux-pci@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net: wwan: iosm: Fix hibernation by re-binding the
 driver around it

On 1/9/25 12:33 AM, Maciej S. Szmigiero wrote:
 @@ -530,3 +531,56 @@ void ipc_pcie_kfree_skb(struct iosm_pcie
*ipc_pcie, struct sk_buff *skb)
>  	IPC_CB(skb)->mapping = 0;
>  	dev_kfree_skb(skb);
>  }
> +
> +static int pm_notify(struct notifier_block *nb, unsigned long mode, void *_unused)
> +{
> +	if (mode == PM_HIBERNATION_PREPARE || mode == PM_RESTORE_PREPARE) {
> +		if (pci_registered) {

Out of sheer ignorance on my side, why 'mode == PM_RESTORE_PREPARE' is
required above? Isn't the driver already unregistered by the previous
PM_HIBERNATION_PREPARE call?

Thanks,

Paolo