netdev - Re: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202501141605.iErAEuFQ-lkp@intel.com>
Date: Tue, 14 Jan 2025 16:48:50 +0800
From: kernel test robot <lkp@...el.com>
To: Michael Chan <michael.chan@...adcom.com>, davem@...emloft.net
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	andrew+netdev@...n.ch, pavan.chebbi@...adcom.com,
	andrew.gospodarek@...adcom.com, somnath.kotur@...adcom.com,
	Ajit Khaparde <ajit.khaparde@...adcom.com>,
	David Wei <dw@...idwei.uk>
Subject: Re: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx
 rings

Hi Michael,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Michael-Chan/bnxt_en-Set-NAPR-1-2-support-when-registering-with-firmware/20250113-144205
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250113063927.4017173-10-michael.chan%40broadcom.com
patch subject: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings
config: csky-randconfig-001-20250114 (https://download.01.org/0day-ci/archive/20250114/202501141605.iErAEuFQ-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250114/202501141605.iErAEuFQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501141605.iErAEuFQ-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_request_irq':
   drivers/net/ethernet/broadcom/bnxt/bnxt.c:11360:16: warning: variable 'j' set but not used [-Wunused-but-set-variable]
   11360 |         int i, j, rc = 0;
         |                ^
   drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_queue_stop':
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:15794:25: error: 'cpr' undeclared (first use in this function); did you mean 'cpu'?
   15794 |         bnxt_db_nq(bp, &cpr->cp_db, cpr->cp_raw_cons);
         |                         ^~~
         |                         cpu
   drivers/net/ethernet/broadcom/bnxt/bnxt.c:15794:25: note: each undeclared identifier is reported only once for each function it appears in


vim +15794 drivers/net/ethernet/broadcom/bnxt/bnxt.c

 15761	
 15762	static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)
 15763	{
 15764		struct bnxt *bp = netdev_priv(dev);
 15765		struct bnxt_rx_ring_info *rxr;
 15766		struct bnxt_vnic_info *vnic;
 15767		struct bnxt_napi *bnapi;
 15768		int i;
 15769	
 15770		for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {
 15771			vnic = &bp->vnic_info[i];
 15772			vnic->mru = 0;
 15773			bnxt_hwrm_vnic_update(bp, vnic,
 15774					      VNIC_UPDATE_REQ_ENABLES_MRU_VALID);
 15775		}
 15776		/* Make sure NAPI sees that the VNIC is disabled */
 15777		synchronize_net();
 15778		rxr = &bp->rx_ring[idx];
 15779		bnapi = rxr->bnapi;
 15780		cancel_work_sync(&bnapi->cp_ring.dim.work);
 15781		bnxt_hwrm_rx_ring_free(bp, rxr, false);
 15782		bnxt_hwrm_rx_agg_ring_free(bp, rxr, false);
 15783		page_pool_disable_direct_recycling(rxr->page_pool);
 15784		if (bnxt_separate_head_pool())
 15785			page_pool_disable_direct_recycling(rxr->head_pool);
 15786	
 15787		if (bp->flags & BNXT_FLAG_SHARED_RINGS)
 15788			bnxt_tx_queue_stop(bp, idx);
 15789	
 15790		napi_disable(&bnapi->napi);
 15791	
 15792		bnxt_hwrm_cp_ring_free(bp, rxr->rx_cpr);
 15793		bnxt_clear_one_cp_ring(bp, rxr->rx_cpr);
 15794		bnxt_db_nq(bp, &cpr->cp_db, cpr->cp_raw_cons);
 15795	
 15796		memcpy(qmem, rxr, sizeof(*rxr));
 15797		bnxt_init_rx_ring_struct(bp, qmem);
 15798	
 15799		return 0;
 15800	}
 15801	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki