netdev - Re: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOBf=mt5Y4YW+jB_4vsZyUHOBv=U2ffXq435EEFWPnKAy6=9dg@mail.gmail.com>
Date: Tue, 14 Jan 2025 10:27:13 +0530
From: Somnath Kotur <somnath.kotur@...adcom.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Michael Chan <michael.chan@...adcom.com>, "David S. Miller" <davem@...emloft.net>, 
	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	Pavan Chebbi <pavan.chebbi@...adcom.com>, 
	Andrew Gospodarek <andrew.gospodarek@...adcom.com>, Ajit Khaparde <ajit.khaparde@...adcom.com>, 
	David Wei <dw@...idwei.uk>
Subject: Re: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings

On Mon, Jan 13, 2025 at 9:31 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Sun, Jan 12, 2025 at 10:39:26PM -0800, Michael Chan wrote:
> > From: Somnath Kotur <somnath.kotur@...adcom.com>
> >
> > In order to use queue_stop/queue_start to support the new Steering
> > Tags, we need to free the TX ring and TX completion ring if it is a
> > combined channel with TX/RX sharing the same NAPI.  Otherwise
> > TX completions will not have the updated Steering Tag.  With that
> > we can now add napi_disable() and napi_enable() during queue_stop()/
> > queue_start().  This will guarantee that NAPI will stop processing
> > the completion entries in case there are additional pending entries
> > in the completion rings after queue_stop().
> >
> > There could be some NQEs sitting unprocessed while NAPI is disabled
> > thereby leaving the NQ unarmed.  Explictily Re-arm the NQ after
> > napi_enable() in queue start so that NAPI will resume properly.
>
> s/Explictily Re-arm/Explicitly re-arm/ (typo + capitalization)
>
> There's a mix of "TX/RX" vs "Tx/Rx" styles in the subjects and commit
> logs of this series.
Sure, thank you will take care of this

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)