netdev - Re: [PATCH net-next 06/11] net: protect NAPI enablement with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250114230036.GA1769770@electric-eye.fr.zoreil.com>
Date: Wed, 15 Jan 2025 00:00:36 +0100
From: Francois Romieu <romieu@...zoreil.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
        jdamato@...tly.com, pcnet32@...ntier.com, anthony.l.nguyen@...el.com,
        przemyslaw.kitszel@...el.com, marcin.s.wojtas@...il.com
Subject: Re: [PATCH net-next 06/11] net: protect NAPI enablement with
 netdev_lock()

Jakub Kicinski <kuba@...nel.org> :
> Wrap napi_enable() / napi_disable() with netdev_lock().
> Provide the "already locked" flavor of the API"
> 
> iavf needs the usual adjustment. A number of drivers call
> napi_enable() under a spin lock, so they have to be modified
> to take netdev_lock() first, then spin lock then call
> napi_enable_locked().
> 
> Protecting napi_enable() implies that napi->napi_id is protected
> by netdev_lock().
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
[...]
> ---
>  include/linux/netdevice.h                   | 11 ++----
>  drivers/net/ethernet/amd/pcnet32.c          | 11 +++++-
>  drivers/net/ethernet/intel/iavf/iavf_main.c |  4 +-
>  drivers/net/ethernet/marvell/mvneta.c       |  5 ++-
>  drivers/net/ethernet/via/via-velocity.c     |  4 +-

For the via-velocity part:

Acked-by: Francois Romieu <romieu@...zoreil.com>

-- 
Ueimor