netdev - Re: [PATCH v3 net-next 2/5] net: no longer assume RTNL is held in flush_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2245508b-a407-4c89-a3ae-3d74a6e2606a@linux.dev>
Date: Tue, 14 Jan 2025 15:01:28 -0800
From: Jesse Brandeburg <jesse.brandeburg@...ux.dev>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
 eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 2/5] net: no longer assume RTNL is held in
 flush_all_backlogs()

On 1/14/25 12:55 PM, Eric Dumazet wrote:
> flush_all_backlogs() uses per-cpu and static data to hold its
> temporary data, on the assumption it is called under RTNL
> protection.
> 
> Following patch in the series will break this assumption.
> 
> Use instead a dynamically allocated piece of memory.
> 
> In the unlikely case the allocation fails,
> use a boot-time allocated memory.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Jesse Brandeburg <jbrandeburg@...udflare.com>