netdev - Re: [PATCH v3 net-next 3/5] net: no longer hold RTNL while calling flush_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb1b4bc3-b6be-42d6-b664-015c0261dec0@linux.dev>
Date: Tue, 14 Jan 2025 15:04:19 -0800
From: Jesse Brandeburg <jesse.brandeburg@...ux.dev>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
 eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 3/5] net: no longer hold RTNL while calling
 flush_all_backlogs()

On 1/14/25 12:55 PM, Eric Dumazet wrote:
> flush_all_backlogs() is called from unregister_netdevice_many_notify()
> as part of netdevice dismantles.
> 
> This is currently called under RTNL, and can last up to 50 ms
> on busy hosts.
> 
> There is no reason to hold RTNL at this stage, if our caller
> is cleanup_net() : netns are no more visible, devices
> are in NETREG_UNREGISTERING state and no other thread
> could mess our state while RTNL is temporarily released.
> 
> In order to provide isolation, this patch provides a separate
> 'net_todo_list' for cleanup_net().
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Jesse Brandeburg <jbrandeburg@...udflare.com>