netdev - Re: [PATCH net-next 05/11] net: protect netdev->napi_list with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4bu_FxxmOZutPp-@LQ3V64L9R2>
Date: Tue, 14 Jan 2025 15:10:52 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org
Subject: Re: [PATCH net-next 05/11] net: protect netdev->napi_list with
 netdev_lock()

On Mon, Jan 13, 2025 at 07:51:11PM -0800, Jakub Kicinski wrote:
> Hold netdev->lock when NAPIs are getting added or removed.
> This will allow safe access to NAPI instances of a net_device
> without rtnl_lock.
> 
> Create a family of helpers which assume the lock is already taken.
> Switch iavf to them, as it makes extensive use of netdev->lock,
> already.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  include/linux/netdevice.h                   | 54 ++++++++++++++++++---
>  drivers/net/ethernet/intel/iavf/iavf_main.c |  6 +--
>  net/core/dev.c                              | 15 ++++--
>  3 files changed, 60 insertions(+), 15 deletions(-)

Reviewed-by: Joe Damato <jdamato@...tly.com>