netdev - Re: [PATCH net-next 09/11] net: protect napi->irq with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4bw-LRerFnH6gIA@LQ3V64L9R2>
Date: Tue, 14 Jan 2025 15:19:20 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org
Subject: Re: [PATCH net-next 09/11] net: protect napi->irq with netdev_lock()

On Mon, Jan 13, 2025 at 07:51:15PM -0800, Jakub Kicinski wrote:
> Take netdev_lock() in netif_napi_set_irq(). All NAPI "control fields"
> are now protected by that lock (most of the other ones are set during
> napi add/del). The napi_hash_node is fully protected by the hash
> spin lock, but close enough for the kdoc...
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  include/linux/netdevice.h | 10 +++++++++-
>  net/core/dev.c            |  2 +-
>  2 files changed, 10 insertions(+), 2 deletions(-)

Reviewed-by: Joe Damato <jdamato@...tly.com>