netdev - Re: [PATCH net-next 02/11] net: add helpers for lookup and walking netdevs under netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250114155149.41cc3ef5@kernel.org>
Date: Tue, 14 Jan 2025 15:51:49 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org
Subject: Re: [PATCH net-next 02/11] net: add helpers for lookup and walking
 netdevs under netdev_lock()

On Tue, 14 Jan 2025 14:53:15 -0800 Joe Damato wrote:
> > +struct net_device *
> > +netdev_xa_find_lock(struct net *net, struct net_device *dev,
> > +		    unsigned long *index)  
> 
> Minor nit, the other added helper functions have docs, but (unless I
> missed it somewhere) this one doesn't. Maybe worthwhile to add
> docs if sending a v2, but probably not worth a re-roll just for
> this.

I didn't add a doc because it's intended for exclusive use by
for_each_netdev_lock_scoped(). Shouldn't be called directly.