netdev - Re: [PATCH v5 02/10] bindings: ipmi: Add binding for IPMB device intf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173689894057.1969633.10540050942005147267.robh@kernel.org>
Date: Tue, 14 Jan 2025 17:57:55 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Ninad Palsule <ninad@...ux.ibm.com>
Cc: kuba@...nel.org, netdev@...r.kernel.org, andrew@...econstruct.com.au, 
 davem@...emloft.net, edumazet@...gle.com, 
 openipmi-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org, 
 joel@....id.au, linux-aspeed@...ts.ozlabs.org, devicetree@...r.kernel.org, 
 conor+dt@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch, 
 minyard@....org, eajames@...ux.ibm.com, 
 linux-arm-kernel@...ts.infradead.org, krzk+dt@...nel.org
Subject: Re: [PATCH v5 02/10] bindings: ipmi: Add binding for IPMB device
 intf

On Tue, 14 Jan 2025 16:01:36 -0600, Ninad Palsule wrote:
> Add device tree binding document for the IPMB device interface.
> This device is already in use in both driver and .dts files.
> 
> Signed-off-by: Ninad Palsule <ninad@...ux.ibm.com>
> ---
>  .../devicetree/bindings/ipmi/ipmb-dev.yaml    | 55 +++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/ipmi/ipmb-dev.example.dts:24.32-33 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/ipmi/ipmb-dev.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250114220147.757075-3-ninad@linux.ibm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.