netdev - Re: [PATCH net-next v2 06/11] net: protect NAPI enablement with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250115090235.44266-1-kuniyu@amazon.com>
Date: Wed, 15 Jan 2025 18:02:35 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <andrew+netdev@...n.ch>, <anthony.l.nguyen@...el.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
	<jdamato@...tly.com>, <marcin.s.wojtas@...il.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <pcnet32@...ntier.com>, <przemyslaw.kitszel@...el.com>,
	<romieu@...zoreil.com>, Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH net-next v2 06/11] net: protect NAPI enablement with netdev_lock()

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 14 Jan 2025 19:53:14 -0800
> Wrap napi_enable() / napi_disable() with netdev_lock().
> Provide the "already locked" flavor of the API.
> 
> iavf needs the usual adjustment. A number of drivers call
> napi_enable() under a spin lock, so they have to be modified
> to take netdev_lock() first, then spin lock then call
> napi_enable_locked().
> 
> Protecting napi_enable() implies that napi->napi_id is protected
> by netdev_lock().
> 
> Acked-by: Francois Romieu <romieu@...zoreil.com> # via-velocity
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>