netdev - Re: [PATCH net-next v2 07/11] net: make netdev netlink ops hold netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250115090731.45263-1-kuniyu@amazon.com>
Date: Wed, 15 Jan 2025 18:07:31 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<horms@...nel.org>, <jdamato@...tly.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH net-next v2 07/11] net: make netdev netlink ops hold netdev_lock()

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 14 Jan 2025 19:53:15 -0800
> In prep for dropping rtnl_lock, start locking netdev->lock in netlink
> genl ops. We need to be using netdev->up instead of flags & IFF_UP.
> 
> We can remove the RCU lock protection for the NAPI since NAPI list
> is protected by netdev->lock already.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>