netdev - Re: [PATCH net-next v2 08/11] net: protect threaded status of NAPI with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250115090910.45363-1-kuniyu@amazon.com>
Date: Wed, 15 Jan 2025 18:09:10 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<horms@...nel.org>, <jdamato@...tly.com>, <leitao@...ian.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, Kuniyuki Iwashima
	<kuniyu@...zon.com>
Subject: Re: [PATCH net-next v2 08/11] net: protect threaded status of NAPI with netdev_lock()

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 14 Jan 2025 19:53:16 -0800
> Now that NAPI instances can't come and go without holding
> netdev->lock we can trivially switch from rtnl_lock() to
> netdev_lock() for setting netdev->threaded via sysfs.
> 
> Note that since we do not lock netdev_lock around sysfs
> calls in the core we don't have to "trylock" like we do
> with rtnl_lock.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>