netdev - Re: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinoJwTa=pyCRDN6q79nTNLz5onRuYzrMdSJ1c4ODiy3ag@mail.gmail.com>
Date: Tue, 14 Jan 2025 17:29:32 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch, 
	pavan.chebbi@...adcom.com, andrew.gospodarek@...adcom.com, 
	somnath.kotur@...adcom.com, Ajit Khaparde <ajit.khaparde@...adcom.com>, 
	David Wei <dw@...idwei.uk>
Subject: Re: [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings

On Mon, Jan 13, 2025 at 12:43 AM Michal Swiatkowski
<michal.swiatkowski@...ux.intel.com> wrote:
>
> On Sun, Jan 12, 2025 at 10:39:26PM -0800, Michael Chan wrote:
> > From: Somnath Kotur <somnath.kotur@...adcom.com>
> > +static int bnxt_tx_queue_start(struct bnxt *bp, int idx)
> > +{
> > +     struct bnxt_tx_ring_info *txr;
> > +     struct netdev_queue *txq;
> > +     struct bnxt_napi *bnapi;
> > +     int rc, i;
> > +
> > +     bnapi = bp->bnapi[idx];
> > +     bnxt_for_each_napi_tx(i, bnapi, txr) {
> > +             rc = bnxt_hwrm_cp_ring_alloc_p5(bp, txr->tx_cpr);
> > +             if (rc)
> > +                     return rc;
> > +
> > +             rc = bnxt_hwrm_tx_ring_alloc(bp, txr, false);
> > +             if (rc) {
> > +                     bnxt_hwrm_cp_ring_free(bp, txr->tx_cpr);
> What about ring allocated in previous steps? Don't you need to free them
> too?

Any failure here will likely cause TX timeout even with the proper
unwind.  I think the correct thing to do is to initiate a reset.  I
will work with Somnath to implement that.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)