netdev - Re: [PATCH net-next 08/10] bnxt_en: Reallocate Rx completion ring for TPH support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4dOe6xxfvt9gB4K@mev-dev.igk.intel.com>
Date: Wed, 15 Jan 2025 06:58:19 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch,
	pavan.chebbi@...adcom.com, andrew.gospodarek@...adcom.com,
	somnath.kotur@...adcom.com, David Wei <dw@...idwei.uk>
Subject: Re: [PATCH net-next 08/10] bnxt_en: Reallocate Rx completion ring
 for TPH support

On Tue, Jan 14, 2025 at 01:42:42PM -0800, Michael Chan wrote:
> On Mon, Jan 13, 2025 at 12:38 AM Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com> wrote:
> >
> > On Sun, Jan 12, 2025 at 10:39:25PM -0800, Michael Chan wrote:
> > > From: Somnath Kotur <somnath.kotur@...adcom.com>
> > > @@ -15669,11 +15689,13 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)
> > >       cancel_work_sync(&rxr->bnapi->cp_ring.dim.work);
> > >       bnxt_hwrm_rx_ring_free(bp, rxr, false);
> > >       bnxt_hwrm_rx_agg_ring_free(bp, rxr, false);
> > > -     rxr->rx_next_cons = 0;
> > Unrelated?
> 
> This line is unneeded.  It gets overwritten by the clone during
> queue_start().  We remove it since we are making related changes in
> this function.  I'll add a comment about this in the Changelog.
> Thanks.

Sure, thanks.

> 
> >
> > >       page_pool_disable_direct_recycling(rxr->page_pool);
> > >       if (bnxt_separate_head_pool())
> > >               page_pool_disable_direct_recycling(rxr->head_pool);
> > >
> > > +     bnxt_hwrm_cp_ring_free(bp, rxr->rx_cpr);
> > > +     bnxt_clear_one_cp_ring(bp, rxr->rx_cpr);
> > > +
> > >       memcpy(qmem, rxr, sizeof(*rxr));
> > >       bnxt_init_rx_ring_struct(bp, qmem);
> > >
> >
> > Rest looks fine:
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>