netdev - Re: [PATCH net] net: dsa: microchip: ksz9477: fix multicast filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55858a5677f187e5847e7941d62f6f186f5d121c.camel@microchip.com>
Date: Thu, 16 Jan 2025 09:06:09 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <tharvey@...eworks.com>
CC: <andrew@...n.ch>, <davem@...emloft.net>, <olteanv@...il.com>,
	<Woojung.Huh@...rochip.com>, <linux-kernel@...r.kernel.org>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<UNGLinuxDriver@...rochip.com>, <kuba@...nel.org>
Subject: Re: [PATCH net] net: dsa: microchip: ksz9477: fix multicast filtering

Hi Tim, 

> Hi Arun,
> 
> Ok, that makes sense to me and falls in line with what my patch here
> was trying to do. When you enable the reserved multicast table it
> makes sense to update the entire table right? You are only updating
> one address/group. Can you please review and comment on my patch
> here?


During my testing of STP protocol, I found that Group 0 of reserved
multicast table needs to be updated. Since I have not worked on other
groups in the multicast table, I didn't update it.

I could not find the original patch to review, it shows "not found" in
lore.kernel.org.

Below are my comments,

- Why override bit is not set in REG_SW_ALU_VAL_B register.
- ksz9477_enable_stp_addr() can be renamed since it updates all the
table entries.




> Best Regards,
> 
> Tim