netdev - RE: [PATCH net] net: dsa: microchip: ksz9477: fix multicast filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM3PR11MB8736EAC16094D3BFF6CE1B30EC1B2@DM3PR11MB8736.namprd11.prod.outlook.com>
Date: Fri, 17 Jan 2025 01:09:21 +0000
From: <Tristram.Ha@...rochip.com>
To: <Arun.Ramadoss@...rochip.com>, <tharvey@...eworks.com>
CC: <andrew@...n.ch>, <davem@...emloft.net>, <olteanv@...il.com>,
	<Woojung.Huh@...rochip.com>, <linux-kernel@...r.kernel.org>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<UNGLinuxDriver@...rochip.com>, <kuba@...nel.org>
Subject: RE: [PATCH net] net: dsa: microchip: ksz9477: fix multicast filtering

> Hi Tim,
> 
> > Hi Arun,
> >
> > Ok, that makes sense to me and falls in line with what my patch here
> > was trying to do. When you enable the reserved multicast table it
> > makes sense to update the entire table right? You are only updating
> > one address/group. Can you please review and comment on my patch
> > here?
> 
> 
> During my testing of STP protocol, I found that Group 0 of reserved
> multicast table needs to be updated. Since I have not worked on other
> groups in the multicast table, I didn't update it.
> 
> I could not find the original patch to review, it shows "not found" in
> lore.kernel.org.
> 
> Below are my comments,
> 
> - Why override bit is not set in REG_SW_ALU_VAL_B register.
> - ksz9477_enable_stp_addr() can be renamed since it updates all the
> table entries.

The reserved multicast table has only 8 entries that apply to 48
multicast addresses, so some addresses share one entry.

Some entries that are supposed to forward only to the host port or skip
should be updated when that host port is not the default one.

The override bit should be set for the STP address as that is required
for receiving when the port is closed.

Some entries for MVRP/MSRP should forward to the host port when the host
can process those messages and broadcast to all ports when the host does
not process those messages, but that is not controllable by the switch
driver so I do not know how to handle in this situation.

The default reserved multicast table forwards to host port on entries 0,
2, and 6; skips host port on entries 4, 5, and 7; forwards to all ports
on entry 3; and drops on entry 1.

enable_stp_addr() is used to enable STP support in all KSZ switches, so
ksz9477_enable_stp_addr() cannot be simply renamed.

It is probably best to have a specific setup_reserved_multicast_table
In KSZ9477 and LAN937X drivers to update those entries.