netdev - Re: [PATCH net 1/3] net: phy: realtek: clear 1000Base-T lpa if link is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4kRFVs6ktqubOJd@mev-dev.igk.intel.com>
Date: Thu, 16 Jan 2025 15:00:53 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/3] net: phy: realtek: clear 1000Base-T lpa if link
 is down

On Wed, Jan 15, 2025 at 02:43:35PM +0000, Daniel Golle wrote:
> Only read 1000Base-T link partner advertisement if autonegotiation has
> completed and otherwise 1000Base-T link partner advertisement bits.
> 
> This fixes bogus 1000Base-T link partner advertisement after link goes
> down (eg. by disconnecting the wire).
> Fixes: 5cb409b3960e ("net: phy: realtek: clear 1000Base-T link partner advertisement")
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  drivers/net/phy/realtek.c | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index f65d7f1f348e..26b324ab0f90 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -1023,23 +1023,20 @@ static int rtl822x_c45_read_status(struct phy_device *phydev)
>  {
>  	int ret, val;
>  
> -	ret = genphy_c45_read_status(phydev);
> -	if (ret < 0)
> -		return ret;
> -
> -	if (phydev->autoneg == AUTONEG_DISABLE ||
> -	    !genphy_c45_aneg_done(phydev))
> -		mii_stat1000_mod_linkmode_lpa_t(phydev->lp_advertising, 0);
> -
>  	/* Vendor register as C45 has no standardized support for 1000BaseT */
> -	if (phydev->autoneg == AUTONEG_ENABLE) {
> +	if (phydev->autoneg == AUTONEG_ENABLE && genphy_c45_aneg_done(phydev)) {
>  		val = phy_read_mmd(phydev, MDIO_MMD_VEND2,
>  				   RTL822X_VND2_GANLPAR);
>  		if (val < 0)
>  			return val;
> -
> -		mii_stat1000_mod_linkmode_lpa_t(phydev->lp_advertising, val);
> +	} else {
> +		val = 0;
>  	}
> +	mii_stat1000_mod_linkmode_lpa_t(phydev->lp_advertising, val);
> +
> +	ret = genphy_c45_read_status(phydev);
> +	if (ret < 0)
> +		return ret;
>  
>  	if (!phydev->link)
>  		return 0;

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> -- 
> 2.47.1