netdev - Re: [PATCH net 2/3] net: phy: realtek: clear master_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4kSLaU8DNSOqJv5@mev-dev.igk.intel.com>
Date: Thu, 16 Jan 2025 15:05:43 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 2/3] net: phy: realtek: clear master_slave_state if
 link is down

On Wed, Jan 15, 2025 at 02:43:43PM +0000, Daniel Golle wrote:
> rtlgen_decode_physr() which sets master_slave_state isn't called in case
> the link is down and other than rtlgen_read_status(),
> rtl822x_c45_read_status() doesn't implicitely clear master_slave_state.
> 
> Avoid stale master_slave_state by always setting it to
> MASTER_SLAVE_STATE_UNKNOWN in rtl822x_c45_read_status() in case the link
> is down.
> 
> Fixes: 081c9c0265c9 ("net: phy: realtek: read duplex and gbit master from PHYSR register")
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  drivers/net/phy/realtek.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 26b324ab0f90..93704abb6787 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -1038,8 +1038,10 @@ static int rtl822x_c45_read_status(struct phy_device *phydev)
>  	if (ret < 0)
>  		return ret;
>  
> -	if (!phydev->link)
> +	if (!phydev->link) {
> +		phydev->master_slave_state = MASTER_SLAVE_STATE_UNKNOWN;
>  		return 0;
> +	}
>  
>  	/* Read actual speed from vendor register. */
>  	val = phy_read_mmd(phydev, MDIO_MMD_VEND2, RTL_VND2_PHYSR);

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> -- 
> 2.47.1