netdev - Re: [PATCH net 3/3] net: phy: realtek: always clear NBase-T lpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4kSZ2FRV+5T3rd7@mev-dev.igk.intel.com>
Date: Thu, 16 Jan 2025 15:06:41 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/3] net: phy: realtek: always clear NBase-T lpa

On Wed, Jan 15, 2025 at 02:45:00PM +0000, Daniel Golle wrote:
> Clear NBase-T link partner advertisement before calling
> rtlgen_read_status() to avoid phy_resolve_aneg_linkmode() wrongly
> setting speed and duplex.
> 
> This fixes bogus 2.5G/5G/10G link partner advertisement and thus
> speed and duplex being set by phy_resolve_aneg_linkmode() due to stale
> NBase-T lpa.
> 
> Fixes: 68d5cd09e891 ("net: phy: realtek: change order of calls in C22 read_status()")
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  drivers/net/phy/realtek.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 93704abb6787..9cefca1aefa1 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -952,15 +952,15 @@ static int rtl822x_read_status(struct phy_device *phydev)
>  {
>  	int lpadv, ret;
>  
> +	mii_10gbt_stat_mod_linkmode_lpa_t(phydev->lp_advertising, 0);
> +
>  	ret = rtlgen_read_status(phydev);
>  	if (ret < 0)
>  		return ret;
>  
>  	if (phydev->autoneg == AUTONEG_DISABLE ||
> -	    !phydev->autoneg_complete) {
> -		mii_10gbt_stat_mod_linkmode_lpa_t(phydev->lp_advertising, 0);
> +	    !phydev->autoneg_complete)
>  		return 0;
> -	}
>  
>  	lpadv = phy_read_paged(phydev, 0xa5d, 0x13);
>  	if (lpadv < 0)

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> -- 
> 2.47.1