netdev - [PATCH] net: phy: c45-tjaxx: add delay between MDIO write and read in soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <AM8P250MB0124A0783965B48A29EFAE6AE11A2@AM8P250MB0124.EURP250.PROD.OUTLOOK.COM>
Date: Thu, 16 Jan 2025 14:55:39 +0000
From: Milos Reljin <milos_reljin@...look.com>
To: andrei.botila@....nxp.com, andrew@...n.ch, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: milos.reljin@...rk.com
Subject: [PATCH] net: phy: c45-tjaxx: add delay between MDIO write and read
 in soft_reset

Add delay before first MDIO read following MDIO write in soft_reset
function. Without this, soft_reset fails and PHY init cannot complete.

Signed-off-by: Milos Reljin <milos_reljin@...look.com>
---
 drivers/net/phy/nxp-c45-tja11xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
index ade544bc007d..be0ca7b12dc3 100644
--- a/drivers/net/phy/nxp-c45-tja11xx.c
+++ b/drivers/net/phy/nxp-c45-tja11xx.c
@@ -1300,7 +1300,7 @@ static int nxp_c45_soft_reset(struct phy_device *phydev)
 	return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1,
 					 VEND1_DEVICE_CONTROL, ret,
 					 !(ret & DEVICE_CONTROL_RESET), 20000,
-					 240000, false);
+					 240000, true);
 }
 
 static int nxp_c45_cable_test_start(struct phy_device *phydev)
-- 
2.34.1