netdev - Re: [PATCH net-next] net: macsec: Add endianness annotations in salt struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250117181826.GT6206@kernel.org>
Date: Fri, 17 Jan 2025 18:18:26 +0000
From: Simon Horman <horms@...nel.org>
To: Ales Nezbeda <anezbeda@...hat.com>
Cc: netdev@...r.kernel.org, sd@...asysnail.net, mayflowerera@...il.com
Subject: Re: [PATCH net-next] net: macsec: Add endianness annotations in salt
 struct

On Fri, Jan 17, 2025 at 12:22:28PM +0100, Ales Nezbeda wrote:
> This change resolves warning produced by sparse tool as currently
> there is a mismatch between normal generic type in salt and endian
> annotated type in macsec driver code. Endian annotated types should
> be used here.
> 
> Sparse output:
> warning: restricted ssci_t degrades to integer
> warning: incorrect type in assignment (different base types)
>     expected restricted ssci_t [usertype] ssci
>     got unsigned int
> warning: restricted __be64 degrades to integer
> warning: incorrect type in assignment (different base types)
>     expected restricted __be64 [usertype] pn
>     got unsigned long long
> 
> Signed-off-by: Ales Nezbeda <anezbeda@...hat.com>

Reviewed-by: Simon Horman <horms@...nel.org>