netdev - Re: [PATCH net-next] net: macsec: Add endianness annotations in salt struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z42Imd8YTQbZL8va@hog>
Date: Mon, 20 Jan 2025 00:19:53 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Ales Nezbeda <anezbeda@...hat.com>
Cc: netdev@...r.kernel.org, mayflowerera@...il.com
Subject: Re: [PATCH net-next] net: macsec: Add endianness annotations in salt
 struct

2025-01-17, 12:22:28 +0100, Ales Nezbeda wrote:
> This change resolves warning produced by sparse tool as currently
> there is a mismatch between normal generic type in salt and endian
> annotated type in macsec driver code. Endian annotated types should
> be used here.
> 
> Sparse output:
> warning: restricted ssci_t degrades to integer
> warning: incorrect type in assignment (different base types)
>     expected restricted ssci_t [usertype] ssci
>     got unsigned int
> warning: restricted __be64 degrades to integer
> warning: incorrect type in assignment (different base types)
>     expected restricted __be64 [usertype] pn
>     got unsigned long long
> 
> Signed-off-by: Ales Nezbeda <anezbeda@...hat.com>
> ---
>  include/net/macsec.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina