netdev - [PATCH] net: usb: qmi_wwan: Add error handling for usbnet_get_ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250120170026.1880-1-vulab@iscas.ac.cn>
Date: Tue, 21 Jan 2025 01:00:26 +0800
From: Wentao Liang <vulab@...as.ac.cn>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Daniele Palmas <dnlplm@...il.com>,
	Breno Leitao <leitao@...ian.org>,
	netdev@...r.kernel.org,
	linux-usb@...r.kernel.org,
	Wentao Liang <vulab@...as.ac.cn>
Subject: [PATCH] net: usb: qmi_wwan: Add error handling for usbnet_get_ethernet_addr

In qmi_wwan_bind(), usbnet_get_ethernet_addr() is called
without error handling, risking unnoticed failures and
inconsistent behavior compared to other parts of the code.

Fix this issue by adding an error handling for the
usbnet_get_ethernet_addr(), improving code robustness.

Fixes: 423ce8caab7e ("net: usb: qmi_wwan: New driver for Huawei QMI based WWAN devices")
Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
---
 drivers/net/usb/qmi_wwan.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index e9208a8d2bfa..7aa576bfe76b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -779,7 +779,9 @@ static int qmi_wwan_bind(struct usbnet *dev, struct usb_interface *intf)
 	/* errors aren't fatal - we can live with the dynamic address */
 	if (cdc_ether && cdc_ether->wMaxSegmentSize) {
 		dev->hard_mtu = le16_to_cpu(cdc_ether->wMaxSegmentSize);
-		usbnet_get_ethernet_addr(dev, cdc_ether->iMACAddress);
+		status = usbnet_get_ethernet_addr(dev, cdc_ether->iMACAddress);
+		if (status < 0)
+			goto err;
 	}
 
 	/* claim data interface and set it up */
-- 
2.42.0.windows.2