netdev - Re: [PATCH] net: usb: qmi_wwan: Add error handling for usbnet_get_ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250120-ginger-oryx-of-eternity-8c9ac9@leitao>
Date: Mon, 20 Jan 2025 09:34:00 -0800
From: Breno Leitao <leitao@...ian.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: Jakub Kicinski <kuba@...nel.org>, Daniele Palmas <dnlplm@...il.com>,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] net: usb: qmi_wwan: Add error handling for
 usbnet_get_ethernet_addr

On Tue, Jan 21, 2025 at 01:00:26AM +0800, Wentao Liang wrote:
> In qmi_wwan_bind(), usbnet_get_ethernet_addr() is called
> without error handling, risking unnoticed failures and
> inconsistent behavior compared to other parts of the code.
> 
> Fix this issue by adding an error handling for the
> usbnet_get_ethernet_addr(), improving code robustness.
> 
> Fixes: 423ce8caab7e ("net: usb: qmi_wwan: New driver for Huawei QMI based WWAN devices")
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

Reviewed-by: Breno Leitao <leitao@...ian.org>