netdev - Re: [PATCH net-next V5 07/11] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e886aaf-e1eb-4f1a-b7ef-f63b350a3320@nvidia.com>
Date: Mon, 20 Jan 2025 13:55:58 +0200
From: Carolina Jubran <cjubran@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <ttoukan.linux@...il.com>
Cc: Tariq Toukan <tariqt@...dia.com>, "David S. Miller"
 <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 Leon Romanovsky <leonro@...dia.com>, netdev@...r.kernel.org,
 Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
 linux-rdma@...r.kernel.org, Cosmin Ratiu <cratiu@...dia.com>,
 Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next V5 07/11] devlink: Extend devlink rate API with
 traffic classes bandwidth management

On 09/12/2024 23:27, Jakub Kicinski wrote:
> On Mon, 9 Dec 2024 23:03:04 +0200 Tariq Toukan wrote:
>>>> +	tc_index = nla_get_u8(tb[DEVLINK_ATTR_RATE_TC_INDEX]);
>>>> +
>>>> +	if (tc_index >= IEEE_8021QAZ_MAX_TCS) {
>>>
>>> This can't be enforced by the policy?
>>>    
>>
>> If we enforce by policy we need to use the constant 7, not the macro
>> IEEE_8021QAZ_MAX_TCS-1.
>> I'll keep it.
> 
> The spec should support using "foreign constants"
> Off the top of my head - you can define the ieee-8021qaz-max-tcs contant
> as if you were defining a devlink constant, then add a header:
> attribute. This will tell C codegen to include that header instead of
> generating the definition.
> 

Hi Jakub,

I tried implementing this as you suggested, but it seems that the only 
supported definition types are ['const', 'enum', 'flags', 'struct'], 
while the max value in checks only accepts patterns matching 
^[su](8|16|32|64)-(min|max)$.

 From what I see, it doesn’t currently support using a const value for 
the max or min checks. Let me know if I’m missing something or if 
there’s an alternative way to achieve this.

Thanks,
Carolina