netdev - Re: [PATCHv2 net] Bonding: Fix support for gso_partial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b702b3c1caaa913905009296fa82e36fae264691.camel@nvidia.com>
Date: Fri, 24 Jan 2025 16:03:32 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "kuba@...nel.org" <kuba@...nel.org>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "liuhangbin@...il.com"
	<liuhangbin@...il.com>, "davem@...emloft.net" <davem@...emloft.net>, Tariq
 Toukan <tariqt@...dia.com>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "razor@...ckwall.org"
	<razor@...ckwall.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "liali@...hat.com" <liali@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "jv@...sburgh.net" <jv@...sburgh.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "horms@...nel.org"
	<horms@...nel.org>, Jianbo Liu <jianbol@...dia.com>, Boris Pismenny
	<borisp@...dia.com>
Subject: Re: [PATCHv2 net] Bonding: Fix support for gso_partial_features

On Fri, 2025-01-24 at 07:38 -0800, Jakub Kicinski wrote:
> On Thu, 23 Jan 2025 15:24:37 +0000 Cosmin Ratiu wrote:
> > I've sent another patch to suggest these changes.
> 
> FTR this is not the normal way to proceed in code review,
> please try to share your feedback rather than taking over
> the submission (unless the original author explicitly asks
> you to).

Apologies, I didn't want to take over the submission, both me and
Hangbin were simultaneously looking to fix this issue. I was about to
send my fix when I saw his proposed one (this thread) and in the
interest of expediting the solution, I decided to send mine in addition
to commenting here.

Given that we were both fixing the same thing, would adding Signed-off-
by with both of us be ok?

Cosmin.